sharkdp/bat

--list-themes + BAT_OPTS can be problematic

Open

#1,618 opened on Apr 25, 2021

View on GitHub
 (8 comments) (1 reaction) (0 assignees)Rust (58,889 stars) (1,557 forks)batch import
buggood first issue

Description

Thank you so much for creating bat! Very happy with the app.

I'm customizing things a bit and my BAT_OPTS is breaking --list-themes. It's paging one theme at a time and the theme names are not shown. That makes it unusable, unfortunately. Maybe we should ignore --paging=always (or perhaps all config) when running that command?

BAT_OPTS="--theme=TwoDark --paging=always --pager='less -j3 -i -J -M -R -S -w -z-4'"

Software version

bat 0.18.0

Operating system

Darwin 19.4.0

Command-line

bat --diagnostic

Environment variables

SHELL=/bin/zsh
PAGER=less
BAT_PAGER=<not set>
BAT_CACHE_PATH=<not set>
BAT_CONFIG_PATH=<not set>
BAT_OPTS="--theme=TwoDark --paging=always --pager='less -j3 -i -J -M -R -S -w -z-4'"
BAT_STYLE=<not set>
BAT_TABS=<not set>
BAT_THEME=<not set>
XDG_CONFIG_HOME=<not set>
XDG_CACHE_HOME=<not set>
COLORTERM=truecolor
NO_COLOR=<not set>
MANPAGER=<not set>

Config file

Could not read contents of '/Users/amd/.config/bat/config': No such file or directory (os error 2).

Compile time information

  • Profile: release
  • Target triple: x86_64-apple-darwin
  • Family: unix
  • OS: macos
  • Architecture: x86_64
  • Pointer width: 64
  • Endian: little
  • CPU features: fxsr,sse,sse2,sse3,ssse3
  • Host: x86_64-apple-darwin

Less version

> less --version 
less 487 (POSIX regular expressions)
Copyright (C) 1984-2016  Mark Nudelman

less comes with NO WARRANTY, to the extent permitted by law.
For information about the terms of redistribution,
see the file named README in the less distribution.
Homepage: http://www.greenwoodsoftware.com/less

Contributor guide

Tech stack
rust
Domain
cli
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Familiarity with RustBasic CLI tool concepts
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65
Research direction
Investigate how the ` list themes` command handles paging options. Look at the argument parsing code in `src/bin/bat/main.rs` or similar files. The fix likely involves overriding paging settings when ` list themes` is used, possibly by ignoring `BAT OPTS` or setting ` paging=never` for that subcommand. Review any existing comments or linked issues for additional context.