sharkdp/bat

--wrap unpaged

Open

#1081 opened on Jun 30, 2020

View on GitHub
 (11 comments) (3 reactions) (0 assignees)Rust (58,889 stars) (1,557 forks)batch import
feature-requestgood first issue

Description

I love it when bat wraps lines in a single page of output. When output needs to be sent to the pager, though, the wrapped lines are actively unhelpful. I'm very used to issuing -S to less once a log file is open to change the line wrapping live.

I'd like a --wrap mode that behaves like auto for unpaged output, but never when piping to less.

Contributor guide

Tech stack
rustshell
Domain
clibackend
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Basic RustUnderstanding of bat's paging logic
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Start by examining the existing ` wrap` flag implementation in `src/bin/bat/clap app.rs` and the wrapping logic in `src/printer.rs`. The discussion in issue comments hints at how `less` is invoked with the ` S` flag; look at how paging is set up in `src/bin/bat/paging.rs`. The request is to add a new wrap mode that defaults to auto for direct terminal output but never wraps when paging. Consider adding a new variant to the `Wrap` enum and adjusting the paging setup to pass the correct ` no wrap` flag to `less`.