shadowsocks/shadowsocks-windows

Client doesn't respect Windows 10 language preferences, no proper way to switch UI to English

Open

#2,926 opened on Jul 28, 2020

View on GitHub
 (6 comments) (4 reactions) (0 assignees)C# (59,558 stars) (16,275 forks)batch import
help wantednew featurepull requests welcome

Description

Describe the bug

The client displays the UI in the language defined by regional formats. In my case, I have English as the preferred language and Russian as the regional format language. The result is that the UI is in Russian, while I expect English.

The client should rely on the preferred user language (see more below).

Environment

  • Shadowsocks client version: 4.1.10.0
  • OS version: Windows 10 20H1 (2004)
  • .NET version: 4.8

Steps you have tried

I don't need to try anything, as my Windows is configured correctly according to my preferences.

What did you expect to see?

The UI language should match the preferred (top) language defined in Settings - Time & Language - Language - Preferred languages.

image

What did you see instead?

The UI language matches the language defined in Settings - Time & Language - Language - Regional format.

Notes

Changing the Regional format language to English is not an acceptable solution, because it affects user-wide format settings. I should not be changing the regional formats for the purpose of changing the UI language for a single app.

Either code the client properly, or provide an option to fall back the UI to English.

Contributor guide

Tech stack
csharp
Domain
desktopinternationalization
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
C#.NET localizationWindows language API
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
The issue is that the app uses regional format language instead of preferred UI language. The fix should involve changing the culture setting in the application to use CultureInfo.CurrentUICulture or similar. Look into how the app initializes its culture, possibly in the Program.cs or startup code. Also consider adding a setting to force English. Since there are no linked PRs, a contributor should investigate the current localization code and test on Windows 10 with different language settings.