shadowsocks/shadowsocks-android

"HTTPS handshake took .." info cannot be wrapped around to 2nd line

Open

#2,492 opened on Apr 13, 2020

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Kotlin (11,493 forks)batch import
good first issue

Repository metrics

Stars
 (36,643 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Describe the bug A clear and concise description of what the bug is.

To Reproduce Steps to reproduce the behavior:

  1. Open Shadowsocks app
  2. Click on bottom of the screen "Connected, tap to check ..."
  3. "Success: HTTPS handshake took ..." info cannot display the 2nd line

Expected behavior The info should be displayed in full.

Screenshots 20200413_142125 - Copy 20200413_142126 - Copy

Smartphone (please complete the following information):

  • Device: Samsung S20 20200413_1421257 - Copy

Configuration

I don't believe configuration is related here.

Put an x inside the [ ] that applies.

  • IPv4 server address
  • IPv6 server address
  • Client IPv4 availability
  • Client IPv6 availability
  • Encrypt method:
  • Route
    • All
    • Bypass LAN
    • Bypass China
    • Bypass LAN & China
    • GFW List
    • China List
    • Custom rules
  • IPv6 route
  • Apps VPN mode
    • Bypass mode
  • Remote DNS: 8.8.8.8
  • DNS over UDP
  • Plugin configuration (if applicable):
  • Auto Connect
  • TCP Fast Open
  • If you're not using VPN mode, please supply more details here:

Additional context Issue should be related to system font size/zoom. If changed the font to minimum, the info can be displayed on a single line. However it should be able to show up properly even on two (multiple) lines.

Contributor guide

Research direction
Look in the layout XML file for the activity that displays the success message. The issue is that the TextView with the message is likely set to maxLines=1. Change it to allow multiple lines (e.g., remove maxLines or set to a higher value). Also ensure the text view width is sufficient. Check screenshots for confirmation.
Tech stack
kotlinandroid
Domain
mobile
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
Basic Android developmentUnderstanding of layout XML
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80