servo/webrender

Multiwindow example panics when debug feature is enabled

Open

#3,860 opened on Feb 17, 2020

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Rust (319 forks)github user discovery
help wantedtype: bug

Repository metrics

Stars
 (3,355 stars)
PR merge metrics
 (PR metrics pending)

Description

I try cargo run --bin multiwindow --features=debug and get

thread 'main' panicked at 'assertion failed: profiler.borrow().is_none()', /Users/pavel/.cargo/registry/src/github.com-1ecc6299db9ec823/thread_profiler-0.1.3/src/lib.rs:95:17
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
fish: 'cargo run --bin multiwindow --f…' terminated by signal SIGABRT (Abort)

As far as I understand the problem is in double initializaition of thread_profiler for compositor thread. What do you think about moving it under wr_has_been_initialized condition?

https://github.com/SergeevPavel/webrender/commit/7a2587acb45ba6552f86c9743ce31ceb616f364c

Contributor guide

Research direction
Investigate the double initialization of thread profiler and add a condition to prevent it when the profiler is already initialized.
Tech stack
rust
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Rust
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
85