serverless/serverless

Command sls deploy hang if named pipe (FIFO special file) is in a project directory

Open

#6602 opened on Aug 28, 2019

View on GitHub
 (1 comment) (0 reactions) (0 assignees)JavaScript (46,915 stars) (5,734 forks)batch import
bugcat/packaginghelp wanted

Description

This is a Bug Report

Description

Existing of named pipe (FIFO special file) in a directory of the project makes deployment impossible.

Steps to reproduce:

  • Create a project in the chosen directory
sls create --template aws-python3
  • Create also named pipe (FIFO special file) in this directory
mkfifo pipe
  • Try to deploy
sls deploy

Output: Serverless framework hangs forever on:

Serverless: Packaging service...
Serverless: Excluding development dependencies...

Additional Data

Bug spotted on:

  • macOS Mojave:
Framework Core: 1.50.1
Plugin: 1.3.9
SDK: 2.1.0
  • Ubuntu 18.04.3 LTS
Framework Core: 1.50.1
Plugin: 1.3.9
SDK: 2.1.0

Contributor guide

Tech stack
javascriptnodejsaws
Domain
devopsclicloud
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Node.js basicsUnderstanding of file system operationsFamiliarity with Serverless Framework packaging
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50
Research direction
Investigate the packaging module in the Serverless Framework (likely in `lib/plugins/package` or `lib/plugins/aws/package`). The issue occurs when the packager encounters a FIFO file while walking the project directory. Look for code that reads file contents or streams files, and add a check to skip or handle FIFO special files. The issue has no linked PR or maintainer comments, so confirm the current behavior and propose a fix that excludes named pipes from the packaging process.