serverless-nextjs/serverless-next.js

cannot block all public access for the s3 bucket

Open

#813 opened on Nov 22, 2020

View on GitHub
 (1 comment) (0 reactions) (0 assignees)TypeScript (3,998 stars) (447 forks)batch import
buggood first issue

Description

I am using the serverless next component and I have this setup

nextJsUiApp:
  component: "@sls-next/serverless-component"
  inputs:
    bucketName: xxx
    bucketRegion: xxx
    domain: ["xxxx", "xxxxx.com"]
    nextConfigDir: "../../"
    cloudfront:
      # if you want to use an existing cloudfront distribution, provide it here
      distributionId: xxxxxx
      priceClass: "PriceClass_100"
      origins:
      - url: https://xxxx.s3.amazonaws.com
        private: true

setting the origin private flag to true doesn't seem to do anything to the bucket permissions or policy.

Can i block all public access through any of the config flags?

Contributor guide

Tech stack
typescriptnextjsaws
Domain
backendclouddevops
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
needs investigation
Prerequisites
Basic AWS S3 bucket policy knowledgeUnderstanding of serverless next.js configuration
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30
Research direction
The issue reports that the 'private' flag in the CloudFront origin configuration does not actually block public access to the S3 bucket. Investigate the serverless next.js component source code, likely in the '@sls next/serverless component' package, to see how the bucket policy is set. Check if there is any logic that sets a bucket policy to restrict public access when 'private: true' is specified. Also look for any related issues or pull requests that might have addressed this. The goal is to determine whether this is a missing feature or a bug in the existing implementation.