serverless-nextjs/serverless-next.js

`originUrl.includes("s3")` produces false positives

Open

#761 opened on Nov 3, 2020

View on GitHub
 (1 comment) (0 reactions) (0 assignees)TypeScript (3,998 stars) (447 forks)batch import
buggood first issue

Description

Describe the bug

Hi there! 👋

I'm adding an origin of this form http://foo.s3-website-eu-west-1.amazonaws.com.

As other issues revealed those kind of origins are not an S3OriginConfig but a CustomOriginConfig.

So it might help to exclude these kind of origins, or maybe allow setting an extra flag to to mark an origin as non-S3OriginConfig.

here's the problematic line of code: https://github.com/serverless-nextjs/serverless-next.js/blob/e7b5c1d302eef1daf32d150e0f12f94d4311eb0a/packages/serverless-components/aws-cloudfront/lib/getOriginConfig.js#L18

Contributor guide

Tech stack
typescriptnodejsaws
Domain
cloudinfrastructuredevops
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
basic TypeScriptAWS CloudFront origin config concepts
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
85
Research direction
Look at the referenced line in packages/serverless components/aws cloudfront/lib/getOriginConfig.js line 18. The condition `originUrl.includes('s3')` falsely identifies S3 website endpoints as S3 origins. Research the difference between S3OriginConfig and CustomOriginConfig in AWS CloudFront, and find a more robust way to distinguish them, such as checking domain patterns or using the AWS SDK's origin type detection.