serverless-nextjs/serverless-next.js

Add tests for domain component

Open

#690 opened on Oct 18, 2020

View on GitHub
 (2 comments) (2 reactions) (0 assignees)TypeScript (3,998 stars) (447 forks)batch import
good first issue

Description

As seen in code coverage: https://codecov.io/gh/serverless-nextjs/serverless-next.js/tree/master/packages/serverless-components/domain, domain component has 0% coverage.

Adding tests for this should get us from 79% to ~90% overall coverage.

@SarKurd I remember you wanted to add tests for this. Let me know if you are still interested to add tests or someone else can also take it up

Contributor guide

Tech stack
typescriptjest
Domain
testing
Issue type
test
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
JestTypeScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75
Research direction
Examine the domain component code under packages/serverless components/domain. Look at existing test files for other components (e.g., packages/serverless components/*/ tests /) to understand the testing patterns used in the project. Identify the test framework (likely Jest) and simulate the test setup. Write tests to achieve coverage of the domain component's functions and edge cases, using the Codecov link for guidance on uncovered lines.
Add tests for domain component · serverless-nextjs/serverless-next.js#690 | Good First Issue