Handle undefined correction factors

Open
#14 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
35/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
cpp
Domain
cli

Research direction

Start by locating the fp_correction function and reproduce the h=2, fpr=0.1 case, where the correction collapses around 355 TB and yields inf. Handle this undefined result by using a high f_h value so splitting is discouraged, then verify the problematic parameter combinations no longer cause incorrect behavior.

Written by the indexing model from the issue text.

Description

For certain combinations of parameters, the fp_correction will yield inf.
E.g. for h=2, fpr=0.1, the function collapses at around 355 TB: WolframAlpha Plot

Idea:

  • Set f_h to a high number to discourage splitting (inf is actually a high number :))
Dominant language
C++
Stars
10
Forks
11
Avg merge
6h 46m
Merged PRs (30d)
7

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from seqan/chopper

All issues in seqan/chopper

Similar issues

More C++ issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.