Remove EC2-compat label stamping from ServiceMonitor after EC2 scrape decommission
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 55/100
- Issue type
- Refactor
- Clarity
- Mostly clear
- Activity status
- Quiet
- Tech stack
- go, kubernetes
- Domain
- devops, observability
Research direction
After EC2 scraping is decommissioned and dashboards have migrated, start in internal/controller/nodedeployment/monitoring.go at endpointSpec. Run TestGenerateServiceMonitor_OnlyEC2CompatWhenNothingDerivable and TestGenerateServiceMonitor_EC2CompatLabels, then update them after removing the two compat metricRelabelings entries and their TODO comment. Done means the generated ServiceMonitor no longer stamps instance_name or public_dns.
Written by the indexing model from the issue text.
Description
Context
To let our grafana dashboards show a unified view across EC2-scraped and k8s-scraped sei nodes during the migration, the controller-emitted ServiceMonitor currently stamps two legacy EC2 labels onto every k8s-scraped sample:
instance_name← copy of thepodlabelpublic_dns← copy of thepodlabel
See internal/controller/nodedeployment/monitoring.go (endpointSpec). These were added in #122 to unblock the v6-5 soak on k8s while EC2 scrapes remain live.
Cleanup trigger
Once EC2 scraping for sei-chain nodes is fully decommissioned:
- Migrate dashboards off
instance_name/public_dnstopod(or whatever k8s-native identity label we settle on). - Delete the two compat
metricRelabelingsentries and their TODO comment inendpointSpec. - Update
TestGenerateServiceMonitor_OnlyEC2CompatWhenNothingDerivableandTestGenerateServiceMonitor_EC2CompatLabelsaccordingly.
The stamping is semantically dishonest (public_dns on a pod is not a DNS name), so we do want to clean it up rather than leave it permanently.
- Dominant language
- Go
- Stars
- 1
- Forks
- 2
- Avg merge
- 2h 29m
- Merged PRs (30d)
- 56
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from sei-protocol/sei-k8s-controller
-
Difficulty 5/5 Over a week Newbie friendliness 32/100
-
Difficulty 5/5 Over a week Newbie friendliness 32/100
sei-protocol/sei-k8s-controller#457 · 2 comments ·
-
Difficulty 3/5 1-2 days Newbie friendliness 68/100
-
Difficulty 4/5 3-5 days Newbie friendliness 45/100
-
Difficulty 3/5 1-2 days Newbie friendliness 65/100
All issues in sei-protocol/sei-k8s-controller
Similar issues
-
Difficulty 1/5 Under an hour Newbie friendliness 84/100
-
enhancement needs triage
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
-
kind/cleanup
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
kubernetes-sigs/kueue#15947 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
sympozium-ai/sympozium#627 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 86/100