segment-boneyard/nightmare

feature: add nightmare.cookies.flush()

Open

#1,395 opened on Feb 28, 2018

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (1,076 forks)batch import
3.xFeature RequestHelp Wanted

Repository metrics

Stars
 (19,507 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Based on our discussion in #1296, it'd be good to support: await nightmare.cookies.flush().

That would involve adding the action to action.js along with some tests. Here's the custom action it would be based on:

// try to flush the session data
function CookieFlusher(Nightmare) {
  Nightmare.action(
    'flushCookies',
    (name, options, parent, win, renderer, done) => {
      parent.respondTo('flushCookies', done => {
        win.webContents.session.cookies.flushStore(done)
      })
      done()
    },
    function(done) {
      this.child.call('flushCookies', done)
    }
  )
}

Contributor guide