segment-boneyard/nightmare

refactor: win.webContents.executeJavaScript(src) to use promises

Open

#1387 opened on Feb 28, 2018

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (19,507 stars) (1,076 forks)batch import
3.xHelp Wantedenhancement

Description

This should allow us to remove the javascript.js and enable context isolation for better security.

docs: https://electronjs.org/docs/api/web-contents#contentsexecutejavascriptcode-usergesture-callback

Contributor guide

Tech stack
javascriptnodejs
Domain
tooling
Issue type
refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
basic Electron knowledgepromises in JavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30
Research direction
The issue asks to refactor `win.webContents.executeJavaScript(src)` to use promises instead of callbacks, which would allow removing the `javascript.js` file. The documentation link provided (https://electronjs.org/docs/api/web contents#contentsexecutejavascriptcode usergesture callback) shows the current callback based API. A newcomer should examine the `javascript.js` file in the repository to understand its current usage and then implement the promise based version, ensuring context isolation is enabled.