segment-boneyard/nightmare

refactor: win.webContents.executeJavaScript(src) to use promises

Open

#1,387 opened on Feb 28, 2018

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (1,076 forks)batch import
3.xHelp Wantedenhancement

Repository metrics

Stars
 (19,507 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

This should allow us to remove the javascript.js and enable context isolation for better security.

docs: https://electronjs.org/docs/api/web-contents#contentsexecutejavascriptcode-usergesture-callback

Contributor guide

Research direction
Implement the refactor to use promises for executeJavaScript, removing javascript.js and enabling context isolation.
Tech stack
javascript
Domain
testing
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScriptElectron
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70