securingsincity/react-ace

Disable annotations (useWorker not working)

Open

#275 opened on Oct 2, 2017

View on GitHub
 (11 comments) (0 reactions) (0 assignees)JavaScript (3,859 stars) (615 forks)batch import
Documentationbuggood first issuehelp wanted

Description

Heyo 👋 I'm having trouble disabling the annotations. After searching through some issues, I've tried out the following:

<AceEditor
  value={code}
  mode="javascript"
  theme="github"
  showLineNumbers
  readOnly
  editorProps={{
    $useWorker: false,
  }}
  setOptions={{
    useWorker: false
  }}
/>

As I understand it, setting either setOptions.useWorker or editorProps.$useWorker to false should disable annotations and linting entirely, but it just isn't working. Any ideas?

Thanks!

Contributor guide

Tech stack
javascriptreact
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Reactreact ace
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65
Research direction
Investigate how react ace passes the `useWorker` option to the Ace editor. The issue likely lies in how the `editorProps` and `setOptions` props are merged and passed to the Ace component. Check the source file `src/ace.js` for prop handling. Look at the issue comments for any hints from maintainers or other users. Reproduce the bug using the provided code snippet to confirm the problem.