securingsincity/react-ace

Disable annotations (useWorker not working)

Open

#275 opened on Oct 2, 2017

View on GitHub
 (11 comments) (0 reactions) (0 assignees)JavaScript (615 forks)batch import
Documentationbuggood first issuehelp wanted

Repository metrics

Stars
 (3,859 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Heyo 👋 I'm having trouble disabling the annotations. After searching through some issues, I've tried out the following:

<AceEditor
  value={code}
  mode="javascript"
  theme="github"
  showLineNumbers
  readOnly
  editorProps={{
    $useWorker: false,
  }}
  setOptions={{
    useWorker: false
  }}
/>

As I understand it, setting either setOptions.useWorker or editorProps.$useWorker to false should disable annotations and linting entirely, but it just isn't working. Any ideas?

Thanks!

Contributor guide

Research direction
Investigate the react ace code to see how $useWorker and setOptions.useWorker are handled; check if they are correctly passed to the underlying Ace editor instance and if there is any override.
Tech stack
javascriptreact
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
React
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70