securingsincity/react-ace

Adding completers and Mutliple editors cause completers to fire multiple times

Open

#158 opened on Nov 16, 2016

View on GitHub
 (3 comments) (0 reactions) (0 assignees)JavaScript (3,859 stars) (615 forks)batch import
Needs Examplebughelp wanted

Description

I don't know if this is the correct way to add completers to the editor, I haven't seen any documentation on the right way to do it using react-ace via brace in a component.

I'm adding them in the onLoad of the editor; I have multiple editors on the page. When multiple editors are loaded, the completers fire for each one loaded. The editor results in duplicate completions.

Here is how they are loaded in the onLoad event.

var completers = [ 
    { 
        name: 'name', 
        value: 'val', 
        score: 100, 
        meta: 'item' 
    },
    ...
];

editor.completers.push({
    getCompletions: function(editor, session, pos, prefix, callback) {
        callback(null, completers);
    }
});

I'm not sure if this a bug or an issue with my implementation.

Thanks for the help in advanced.

Contributor guide

Tech stack
javascriptreact
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
React basicsAce editor APICompleter concept
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Investigate how completers are added in the onLoad callback. Check the Ace editor documentation for completers and see if they are being shared across editors. Look at the react ace source code, particularly the component that mounts the Ace editor, to understand how editor instances are managed. Consider testing with a minimal reproduction to confirm duplicate completions.