sealerio/sealer

[unit-test] Correct commented unit tests to take them back

Open

#1,488 opened on Jun 8, 2022

View on GitHubContributor guide
 (1 comment) (0 reactions) (0 assignees)Go (357 forks)github user discovery
good first issuehelp wantedkind/featuretest

Repository metrics

Stars
 (2,095 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

In pull request https://github.com/sealerio/sealer/pull/1476, we have succeeded in making unit-test work. While after that pull request, we found that we have very few unit test coverage, and this will definitely lead to the poor quality of sealer.

So I think we should try to gradually add all those commented unit tests back.

And we encourage the all community participants could feel free to help and contribute.

The example comment test case is like :

https://github.com/sealerio/sealer/blob/main/build/layerutils/charts/charts_test.go#L17-L47

https://github.com/sealerio/sealer/blob/main/pkg/config/config_test.go#L24-L106

and so on.

Contributor guide

Research direction
Find commented unit tests in the codebase (e.g., build/layerutils/charts/charts test.go and pkg/config/config test.go), uncomment them, run tests, and fix any failures.
Tech stack
go
Domain
backend
Issue type
Test
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GoTesting
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80