scrapinghub/arche

Use `pool` to download items with `filter`

Open

#13 opened on Dec 25, 2018

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Python (17 forks)auto 404
Type: BugType: Performancegood first issue

Repository metrics

Stars
 (47 stars)
PR merge metrics
 (PR metrics pending)

Description

The current logic of dividing on batches by start_index and count doesn't account for filter. When using filter, returned items _key don't correspond with actual index so the data repeats.

Contributor guide

Research direction
Investigate the batch downloading logic in the pool module to understand how filter affects the index mapping and propose a fix to avoid data repetition.
Tech stack
python
Domain
backenddata
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitPython
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75