scottyab/showhidepasswordedittext

allow setting of text instead of an icon

Open

#15 opened on May 12, 2016

View on GitHub
 (0 comments) (2 reactions) (0 assignees)Java (560 stars) (83 forks)batch import
enhancementhelp wanted

Description

Show/Hide text is less mental strain to understand and can be localised.

  • Add two new attributes show_text and hide_text and corresponding java methods.
  • If text set then use this in preference over drawable

Suggestion: treat the text as a drawable create inner class that extends Drawable. This way it can just be handled as a drawable and the logic of the view can stay the same (not if text do this). If possible get the typeface from the edittext in case a custom font has been set.

Contributor guide

Tech stack
javaandroid
Domain
mobileaccessibility
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Basic Android developmentCustom Drawable implementationXML attribute handling
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Examine the existing PasswordEditText view class (likely in the main source directory) and the current drawable handling. Create a custom Drawable subclass as suggested. Implement the show text and hide text attributes in attrs.xml. Modify the view to use the text drawable when these attributes are set. Ensure typeface inheritance from the EditText.