scottyab/showhidepasswordedittext

allow setting of text instead of an icon

Open

#15 opened on May 12, 2016

View on GitHub
 (0 comments) (2 reactions) (0 assignees)Java (83 forks)batch import
enhancementhelp wanted

Repository metrics

Stars
 (560 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Show/Hide text is less mental strain to understand and can be localised.

  • Add two new attributes show_text and hide_text and corresponding java methods.
  • If text set then use this in preference over drawable

Suggestion: treat the text as a drawable create inner class that extends Drawable. This way it can just be handled as a drawable and the logic of the view can stay the same (not if text do this). If possible get the typeface from the edittext in case a custom font has been set.

Contributor guide

Research direction
Implement show text and hide text attributes in the custom view, create a TextDrawable that extends Drawable to render the localized text, and integrate it with the existing toggle logic.
Tech stack
java
Domain
mobile
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Java
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70