scotttrinh/shootproof-js-sdk

Check "stat" property for errors and failures

Open

#2 opened on Feb 22, 2016

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (0 forks)github user discovery
help wanted

Repository metrics

Stars
 (1 star)
PR merge metrics
 (No merged PRs in 30d)

Description

Looks like the server returns a 200 even on errors, but passes back an error object. Let's add response parsing to check for a successful status and reject on errors. Need some feedback about the possible responses, or at least the possible stat values.

Contributor guide

Research direction
Investigate the possible values of the 'stat' property from the API documentation or sample responses. Then add conditional logic to check if stat indicates success or error, and reject the promise accordingly.
Tech stack
javascript
Domain
api
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
JavaScriptREST API concepts
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75