s2i run exits with exit-code 0 if no way to run the app was found

Open Beginner friendly
#655 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
1/5
Estimated time
Under an hour
Newbie friendliness
88/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Active
Tech stack
shell
Domain
devops

Research direction

Start with the s2i/run script and compare its fall-through behavior with the linked s2i-python-container src/s2i/bin/run implementation. Verify the path taken when no webserver can be started, then ensure that path exits with code 1 rather than 0.

Written by the indexing model from the issue text.

Description

s2i/run script currently exits with code 0 when no way to run the container was found. s2i-python-container's approach should IMO instead be followed where the script exits 1 if it falls through and no webserver is able to be started for one reason or another: https://github.com/sclorg/s2i-python-container/blob/cc6d266cb1e9641c1f547da1d0c6094352b4e47c/src/s2i/bin/run#L161

Dominant language
Shell
Stars
54
Forks
156
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from sclorg/s2i-ruby-container

All issues in sclorg/s2i-ruby-container

Similar issues

More Shell/Bash issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.