Add test suite in case of FIPS is enabled
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 35/100
- Issue type
- Feature
- Clarity
- Mostly clear
- Activity status
- Stale
- Domain
- ci-cd, security, testing-qa
Research direction
Start by comparing the existing .github/workflows files with the referenced s2i-nodejs-container FIPS workflow and review test/test-lib-nodejs.sh. Check /proc/sys/crypto/fips_enabled and define tests for both host-disabled and host-enabled FIPS cases, including Python application detection. Done means the workflow runs and both requested test cases pass or fail as specified.
Written by the indexing model from the issue text.
Description
It would be nice to test in upstream also python container in case of FIPS is enabled on host machine.
- First of all the GitHub Action should be present in directory
.github/workflows. The content should be similar like this https://github.com/sclorg/s2i-nodejs-container/blob/master/.github/workflows/container-fips-tests.yml - The second one are alone tests.
- In case of FIPS mode is disabled on host, then Python FIPS mode should not be execute at all or it should fail.
- In case of FIPS mode is enabled on host, then detection if FIPS mode from python point of view has to passed.
The detection of FIPS mode is present in this file /proc/sys/crypto/fips_enabled.
It would be nice to have two test cases.
- check FIPS from ruby code like it is here: https://github.com/sclorg/s2i-nodejs-container/blob/master/test/test-lib-nodejs.sh#L485
- check FIPS from python application point of view.
A similar pull request in s2i-nodejs-container is here: github.com/sclorg/s2i-nodejs-container/pull/493, where you can take inspiration.
- Dominant language
- Shell
- Stars
- 271
- Forks
- 329
- PR merge metrics
- No merged PRs in 30d
Getting set up
We have not checked this project's setup files yet. Start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from sclorg/s2i-python-container
-
Difficulty 5/5 Over a week Newbie friendliness 25/100
sclorg/s2i-python-container#813 · 4 comments ·
-
Difficulty 4/5 3-5 days Newbie friendliness 35/100
sclorg/s2i-python-container#540 · 1 comment ·
-
Difficulty 5/5 Over a week Newbie friendliness 20/100
sclorg/s2i-python-container#368 · 7 comments ·
-
enhancement P3
Difficulty 5/5 Over a week Newbie friendliness 15/100
sclorg/s2i-python-container#304 · 8 comments · 2 reactions ·
-
help wanted openshift
Difficulty 4/5 3-5 days Newbie friendliness 35/100
sclorg/s2i-python-container#280 · 12 comments ·
All issues in sclorg/s2i-python-container
Similar issues
-
out-of-date
Difficulty 1/5 Under an hour Newbie friendliness 82/100
CachyOS/CachyOS-PKGBUILDS#1917 ·
Maintainers usually reply within 1 day
-
package-update
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
-
bug needs triage
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
EmbarkStudios/cargo-about#323 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
vllm-project/vllm-metal#841 ·
Maintainers usually reply within 1 day