schollz/find3

Add log rotation

Open

#6 opened on Mar 4, 2018

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Go (368 forks)github user discovery
enhancementgood first issue

Repository metrics

Stars
 (4,782 stars)
PR merge metrics
 (PR metrics pending)

Description

The logfiles can get large, especially if there's a lot of fingerprints and/or -debug has been turned on. (I'm thinking of main.stdout).

It may be worth looking into automatically rotating this.

Maybe something like lumberjack? Seems like an easy swap.

Alternatively, if we want to push this onto the user, we should mention this explicitly in README.md.

Contributor guide

Research direction
Add log rotation using the lumberjack library. Implement a logger that writes to a file and rotates based on size and age, or alternatively document log management for users.
Tech stack
go
Domain
backend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Go
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
90