schickling/chromeless

Using `press(13)` will incorrectly prompt the auto update setting page in Canary

Open

#222 opened on Aug 11, 2017

View on GitHub
 (5 comments) (3 reactions) (0 assignees)TypeScript (13,240 stars) (606 forks)batch import
APIhelp wantedquestion

Description

Example:

        .click('#search-button')
        .type('funny', 'input#search-input')
        .press(13)

The expected behaviour is to redirect to a search page since I try to trigger an enter event in the input box. However, a new tab is opened instead.

Contributor guide

Tech stack
typescript
Domain
testing
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Understanding of chromeless APIBasic knowledge of Chrome automation
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
35
Research direction
Investigate why pressing the Enter key (key code 13) triggers Chrome's auto update setting page instead of performing the expected search action. Review the 'press' method implementation in the chromeless library to check how key events are dispatched. Consider whether the issue is specific to Chrome Canary's hotkey handling and if there is a need to prevent default behavior or use a different event simulation approach.