schickling/chromeless

Support for setFileInput() over Proxy

Open

#186 opened on Aug 6, 2017

View on GitHub
 (2 comments) (0 reactions) (0 assignees)TypeScript (13,240 stars) (606 forks)batch import
Proxyenhancementhelp wanted

Description

setFileInput() was implemented in #170. However, the setFileInput() does not currently work over the Proxy as expected because files are not transmitted from the local Chromeless instance to the Proxy (something which may be difficult given the AWS IoT 128KB message size limit.)

This issue tracks progress on supporting the Proxy.

Acceptance Criteria

  • Add support to setFileInput() for S3 paths (which means fetching the S3 file, then passing the local disk path from the resulting object to setFileInput()
  • Add support to setFileInput() for URLs
  • if a local file path is provided to setFileInput() we will try to upload it to S3, then pass the S3 path to the Proxy.
await chromeless.selectFile('.uploader', [
  's3://my-bucket/my/object/prefix/file.jpg',
  'http://sweet-site.cool/my-image.jpg'
])

Contributor guide

Tech stack
typescriptaws
Domain
testingbackend
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
4
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
over 1 week
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
AWS S3Chromeless internalsProxy architecture
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
20
Research direction
The issue requires implementing support for setFileInput() over the Chromeless Proxy. The main challenge is transmitting files given AWS IoT's 128KB message size limit. The acceptance criteria suggest using S3 paths and URLs, with fallback uploading local files to S3. Reference PR #170 for the initial implementation. Investigate how the proxy currently handles other commands and design a mechanism to fetch S3 objects or HTTP URLs and pass the file path to setFileInput(). Files likely involved are in the Chromeless source code related to the proxy and file input handling.