schickling/chromeless

Pass chromePath and chromeFlags in Chromeless options to chrome-launcher

Open

#184 opened on Aug 6, 2017

View on GitHub
 (0 comments) (4 reactions) (0 assignees)TypeScript (13,240 stars) (606 forks)batch import
APIfeaturehelp wanted

Description

Add chromePath and chromeFlags to ChromelessOptions which get passed to the chrome-launcher's constructor so that users can specify a path to their Chrome installation and provide custom flags.

Brought up in https://github.com/graphcool/chromeless/issues/158#issuecomment-320455862

Contributor guide

Tech stack
typescriptnodejs
Domain
testingbackend
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Basic TypeScript knowledgeFamiliarity with chrome launcher
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75
Research direction
The issue requests adding `chromePath` and `chromeFlags` to `ChromelessOptions` and passing them to the `chrome launcher` constructor. Look at the current `ChromelessOptions` type definition (likely in `src/index.ts` or similar) and the section where `chrome launcher` is instantiated (e.g., `src/chromeless.ts`). Check the referenced issue #158 for context. Implement by extending the options interface and modifying the `chrome launcher` call to pass the new properties. Ensure TypeScript types are updated accordingly.