scalameta/metals

When a name like `res2` is used in a worksheet, it causes a double definition

Open

#5,680 opened on Sep 26, 2023

View on GitHub
 (3 comments) (0 reactions) (0 assignees)Scala (2,300 stars) (421 forks)batch import
buggood first issueworksheets

Description

Describe the bug

  1. Open a worksheet
  2. Type a few lines of results to be evaluated.
  3. Define a value named val res2 = 1 to see error. res2

Expected behavior

Should evaluate OK.

Operating system

Linux

Editor/Extension

VS Code

Version of Metals

v1.0.1

Extra context or search terms

worksheet, result, double definition, Mdoc

Contributor guide

Tech stack
scala
Domain
developer experiencetooling
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
ScalaMetals source codeworksheet evaluation
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65
Research direction
Investigate how worksheet results are assigned variable names (likely 'res1', 'res2', etc.) in Metals. Look at the worksheet evaluation code, possibly in `WorksheetProvider` or related files. Check for any existing handling of name collisions. The fix might involve generating unique names or using a different prefix that doesn't conflict with user defined names. Review issue comments for additional insights.