scalameta/metals

Clean constructor parameters for `Indexer` and `ScalaCli`

Open

#4,788 opened on Jan 1, 2023

View on GitHub
 (5 comments) (0 reactions) (0 assignees)Scala (421 forks)batch import
good first issueimprovementtech debt

Repository metrics

Stars
 (2,300 stars)
PR merge metrics
 (Avg merge 3d 11h) (122 merged PRs in 30d)

Description

Another follow up after https://github.com/scalameta/metals/pull/4776.

There's need to pass every constructor argument as a function in scala.meta.internal.metals.Indexer and scala.meta.internals.ScalaCli

  • Usually, replacing () =>, should be straighforward change, but sometimes () => was used to capture mutable state.
  • probably Indexerand ScalaCli aren't the only ones which can be refactored. Person doing this task can browse other classes (optional)

Contributor guide

Research direction
Identify constructor parameters in Indexer and ScalaCli that use `() =>` and replace them with direct values or other mechanisms if possible, ensuring mutable state is handled correctly.
Tech stack
None
Domain
backend
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Scala
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70