saveourtool/save-cloud

Improve testing of background tasks

Open

#240 opened on Aug 27, 2021

View on GitHub
 (0 comments) (0 reactions) (1 assignee)Kotlin (4 forks)github user discovery
enhancementgood first issue

Repository metrics

Stars
 (38 stars)
PR merge metrics
 (PR metrics pending)

Description

We have a lot of cases, when request handler returns and triggers a background job, i.e. subscribes to a Publisher inside it's doOnSuccess. In tests to verify that backgound jobs are working correctly we usually call Thread.sleep. This is sub-optimal, because jobs take indefinite time and blocking increases duration of tests.

Contributor guide

Research direction
Replace Thread.sleep with a more robust mechanism like using test frameworks' async support or coroutines to await background job completion. Consider using `kotlinx.coroutines.test` or similar tools.
Tech stack
kotlin
Domain
backend
Issue type
Test
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Kotlintesting experience
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60