saveourtool/save-cli

Use kotest-assertions

Open

#408 opened on Jun 23, 2022

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Kotlin (4 forks)auto 404
enhancementgood first issuerefactoringtests

Repository metrics

Stars
 (43 stars)
PR merge metrics
 (PR metrics pending)

Description

kotest-assertions support multiplatform and are much more expressive than what's available in kotlin.test.

For example, this code

reporter.results.forEach { testResult ->
            assertTrue(!testResult.debugInfo!!.execCmd!!.contains("chapter"))
        }

will fail with Expected value to be true.. However with kotest it can be rewritten similarly to

reporter.results shouldNot exist { testResult ->
        testResult.debugInfo!!.execCmd!!.contains("chapter")
}

which will on failure describe the collection that has been tested

Contributor guide

Research direction
Replace existing kotlin.test assertions with kotest assertions library for more expressive test failure messages.
Tech stack
kotlin
Domain
backendtesting
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Kotlin
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
90