saveourtool/diktat

Rule: Create variable for long conditions and use them instead

Open

#829 opened on Apr 9, 2021

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Kotlin (40 forks)github user discovery
enhancementgood first issue

Repository metrics

Stars
 (571 stars)
PR merge metrics
 (PR metrics pending)

Description

In case of some long condition

if (cond1 && cond2 && cond3 && .....) {
}

It's better to create an additional variable for more readability

val condition = cond1 && cond2 && cond3 && .....
if (condition) {
}

Contributor guide

Research direction
Study existing rules in diktat to understand the pattern for adding new rules, then implement a rule that suggests extracting long conditions into a variable.
Tech stack
kotlin
Domain
tooling
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
KotlinGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70