saveourtool/diktat

Enhance NullChecksRule

Open

#822 opened on Apr 5, 2021

View on GitHub
 (0 comments) (0 reactions) (1 assignee)Kotlin (40 forks)github user discovery
enhancementgood first issueneeded

Repository metrics

Stars
 (571 stars)
PR merge metrics
 (PR metrics pending)

Description

    grandParent != null && grandParent.elementType == VALUE_ARGUMENT_LIST

can be simplified:

    grandParent?.elementType == VALUE_ARGUMENT_LIST

Contributor guide

Research direction
Locate the NullChecksRule implementation in the source code and simplify the condition as suggested.
Tech stack
kotlin
Domain
tooling
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
KotlinGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80