saveourtool/diktat

FP in `RUN_IN_SCRIPT` rule

Open

#1,693 opened on Jun 9, 2023

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Kotlin (40 forks)github user discovery
buggood first issue

Repository metrics

Stars
 (571 stars)
PR merge metrics
 (PR metrics pending)

Description

@Suppress("RUN_IN_SCRIPT", "AVOID_NULL_CHECKS")
    plugins {
        id("com.saveourtool.diktat.buildutils.detekt-convention-configuration")
        // FixMe: remove after 2.0.0
        if (System.getenv("DIKTAT_SNAPSHOT") != null) {
            id("com.saveourtool.diktat.buildutils.diktat-convention-configuration")
        }
    }

should not cause error:

     "results": [
        {
          "level": "error",
          "locations": [
            {
              "physicalLocation": {
                "artifactLocation": {
                  "uri": "gradle/plugins/build.gradle.kts",
                  "uriBaseId": "%SRCROOT%"
                },
                "region": {
                  "startColumn": 1,
                  "startLine": 25
                }
              }
            }
          ],
          "message": {
            "text": "[RUN_IN_SCRIPT] wrap blocks of code in top-level scope functions like `run`: @Suppress(\"COMMENTED_OUT_CODE\", \"WRONG_INDENTATION\")..."
          },
          "ruleId": "diktat-ruleset:run-script"

Contributor guide