saveourtool/diktat

`FILE_UNORDERED_IMPORTS` false positive when the list of imports contains an alias import

Open

#1,494 opened on Aug 9, 2022

View on GitHub
 (0 comments) (0 reactions) (1 assignee)Kotlin (40 forks)github user discovery
buggood first issue

Repository metrics

Stars
 (571 stars)
PR merge metrics
 (PR metrics pending)

Description

Traditionally, IDEA places all alias imports into a separate group which can't be removed:

import-layout

On the contrary, diKTat doesn't distinguish between regular and alias imports and requires that all imports are sorted alphabetically.

As a workaround, the user has to suppress FILE_UNORDERED_IMPORTS whenever alias imports are used:

@file:Suppress("FILE_UNORDERED_IMPORTS")

package com.example

import java.lang.String

import org.assertj.core.api.Assertions.assertThat
import org.junit.jupiter.api.TestMethodOrder
import org.junit.jupiter.params.ParameterizedTest
import org.junit.jupiter.params.provider.ValueSource

import java.lang.Object as JvmObject

Environment information

  • diktat version: 1.2.3

Contributor guide

Research direction
Examine diktat's import sorting logic in the FILE UNORDERED IMPORTS rule. Identify where alias imports (e.g., `import ... as ...`) are not properly sorted or grouped. Consider adding a configuration option to treat alias imports separately or update the sorting comparator to handle aliases.
Tech stack
kotlin
Domain
tooling
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Kotlin
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60