saveourtool/diktat

Explicit lambda arguments shouldn't be called `it`

Open

#1,250 opened on Mar 28, 2022

View on GitHub
 (1 comment) (0 reactions) (1 assignee)Kotlin (40 forks)github user discovery
enhancementhelp wanted

Repository metrics

Stars
 (571 stars)
PR merge metrics
 (PR metrics pending)

Description

Explicit lambda arguments are named it. This is confusing, even though the language allows it. I'll create a separate issue to implement this check as a part of Diktat.

Originally posted by @petertrr in https://github.com/analysis-dev/diktat/issues/1228#issuecomment-1080781871

Contributor guide

Research direction
Implement a new Diktat rule that detects explicit lambda parameters named 'it' and suggests renaming them.
Tech stack
kotlin
Domain
tooling
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Kotlin
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70