saurabhdaware/visconf

Forward button does not work when $wait timeout is fired

Open

#12 opened on Mar 13, 2020

View on GitHubContributor guide
 (0 comments) (0 reactions) (0 assignees)JavaScript (3 forks)github user discovery
bughelp wantedv1.0.0

Repository metrics

Stars
 (33 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Steps to reproduce

  • Create a talk with $wait10s somewhere in the transcript.
  • When 10 seconds pause is fired, try pressing forward button or backward button

Expected Behavior

  • When Forward or Backward is pressed, the timeout should be canceled.

Problem?

when the talk discovers $wait10s it calls a function await wait(10000) which is promisified version of setTimeout (the function is defined in scripts/helpers.js). When it fires it waits for the promise to resolve to continue. Meanwhile, if you press forward it will go forward but after promise is resolved it will go back to the previous slide.

Contributor guide

Research direction
Cancel the $wait timeout when forward or backward button is pressed. Use a reference to setTimeout and clearTimeout on button press.
Tech stack
javascript
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70