saurabhdaware/DEV-widget

Refactor the themes part

Open

#16 opened on Nov 27, 2019

View on GitHubContributor guide
 (1 comment) (0 reactions) (0 assignees)JavaScript (11 forks)github user discovery
Needs Discussionenhancementhelp wantedrefactorit

Repository metrics

Stars
 (99 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

So currently if someone wants to create a theme they have to go to the card.style.mjs and add a class with name of the theme and set the css variables.

This is super useful and makes things extremely easy to create themes but as we go adding themes we go on increasing the numbers of lines in the JavaScript string (the css is just javascript string). It would be helpful if there is any other way to handle this since I don't want to go on making the response size larger and larger.

Contributor guide

Research direction
Explore alternatives such as extracting CSS into separate files, using CSS in JS libraries, or leveraging CSS custom properties more efficiently to avoid bloating the JavaScript response.
Tech stack
javascript
Domain
frontend
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60