sass/dart-sass

Support globs on the command line

Open

#616 opened on Mar 6, 2019

View on GitHub
 (13 comments) (10 reactions) (0 assignees)Dart (4,192 stars) (376 forks)batch import
CLIenhancementhelp wanted

Description

Latest Sass on both Windows & OSX I get the following error

video.js@7.5.0 build:css:cdn: sass src/css/vjs-cdn.scss dist/alt/video-js-cdn.css "--watch" "'src/**/**/*.scss'"

This command works fine as-is in node-sass, but errors out in dart-sass. I would expect only a warning & ignoring the (unused) parameter.

Removing the parameter works well.

Perhaps the project I'm working on is unusual; older codebase but doesn't use grunt/gulp, but uses CLI commands in package.json (which is more of a current trend).

Contributor guide

Tech stack
None
Domain
cli
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Basic knowledge of CLIUnderstanding of glob patterns
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Investigate how dart sass currently handles command line file arguments. Look at the argument parser in the source code (likely in the bin entry point). The issue mentions that glob patterns passed as a string cause an error. Research how node sass implements glob support and consider using a glob library compatible with Dart. Check existing comments for any maintainer suggestions or rejected approaches.