sass/dart-sass

Legacy JS API does not handle symlinks properly

Open

#1687 opened on May 4, 2022

View on GitHub
 (8 comments) (0 reactions) (0 assignees)Dart (4,192 stars) (376 forks)batch import
bughelp wanted

Description

this is with npm sass .

relative import fails when it starts with 2 dots @import ../some-style.

I also checked how fs.existsSync handles paths with .. in it. on linux fs.existsSync fails to find the file if the path contains .., on windows it works...

Contributor guide

Tech stack
javascriptnodejs
Domain
tooling
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
needs investigation
Prerequisites
Node.js filesystem basicssymlink concept
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30
Research direction
The bug is in the legacy JS API of dart sass where relative imports with '..' fail on Linux due to symlink handling. Investigate how fs.existsSync and related functions handle paths with '..' on Linux vs Windows. Look at the JS API source (likely in lib/src/legacy.js or similar) to understand the import resolution logic. Check if there are any existing tests for symlink behavior. The fix may involve using realpath or fs.realpathSync to resolve symlinks before checking file existence.