sapegin/react-spaceman

react-spaceman and serverside rendering

Open

#4 opened on Dec 5, 2017

View on GitHub
 (7 comments) (0 reactions) (0 assignees)TypeScript (8 forks)github user discovery
enhancementhelp wanted

Repository metrics

Stars
 (59 stars)
PR merge metrics
 (PR metrics pending)

Description

Hi again!

Since attachStyles relies on document being defined, I just realized it's currently impossible for us to use it with our CSS modules + SSR setup.

That's a major bummer because we really like it :)

We are considering making a PR but since our setup is a bit specific, maybe we would need to fork, which I would really like to avoid.

Do you have any suggestions how to approach this?

Thanks a lot a for answering these questions!

Contributor guide

Research direction
Modify attachStyles to check for document and window before accessing them; use conditional rendering that works on server.
Tech stack
typescriptreact
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
ReactSSR
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60