sangria-graphql/sangria

New middleware to limit visibility of schema elements

Open

#417 opened on Nov 12, 2018

View on GitHub
 (0 comments) (1 reaction) (0 assignees)Scala (1,961 stars) (219 forks)batch import
featurehelp wanted

Description

The idea is to provide a middleware that allows to hide specific fields and types based on arbitrary logic. There hidden parts of the schema should be unavailable:

  • During the execution
  • During input value coercion (it should be possible to hide input as well as output types)
  • During validation
  • In the introspection results

The validation might be tricky since it is not aware of the middleware right now. On the other had, if for example a field is hidden, GraphQL query that uses the field should produce a violation during the validation phase. So maybe this feature needs to implemented as a new concept in the library and not necessarily as a middleware.

It should be possible to "hide" following elements of the schema:

  • Type (input and output)
  • Field (input and output)
  • Argument
  • Enum value

This idea is inspired by "Limiting Visibility" feature in graphql-ruby:

http://graphql-ruby.org/schema/limiting_visibility.html

Contributor guide

Tech stack
scala
Domain
backendsecurity
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
4
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
over 1 week
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
GraphQL schema designsangria middleware systemScala
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
25
Research direction
Review the current middleware implementation in sangria (e.g., Middleware.scala) to understand how middleware hooks into execution and validation. Study the graphql ruby visibility feature for design patterns. Investigate the validation phase (ValidationRule.scala) to see how to propagate visibility restrictions. Propose a design that integrates with the existing schema traits.