sangria-graphql/sangria

Add deriveInterfaceType

Open

#263 opened on Jul 8, 2017

View on GitHub
 (2 comments) (0 reactions) (0 assignees)Scala (1,961 stars) (219 forks)batch import
derive-macrosfeaturehelp wanted

Description

Would be cool to have this for traits

trait MyInterface {
  def id: Int
  name: String
}
val MyInterfaceType = deriveInterfaceType[Unit, MyInterface]()

I think that another solution that is closer to deriveObjectType could be

case class MyInterfaceImpl(id: Int, name: String) extends MyInterface
val MyInterfaceType = deriveInterfaceType[Unit, MyInterfaceImpl](InterfaceTypeName("MyInterface"))

This would help because you don't have to copy & paste the field names into another definition

Contributor guide

Tech stack
scala
Domain
api
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
ScalaSangriaMacros
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
25
Research direction
First, locate the deriveObjectType macro implementation in the sangria codebase (likely in a macro directory). Study how it derives fields for case classes and adapt the pattern for traits. Then, implement a deriveInterfaceType macro that works for traits, either directly from trait methods or via a case class wrapper. Check related issues for any prior discussion or design decisions.