sandstorm-io/sandstorm

GitHub authentication doesn't set the correct primary email

Open

#3665 opened on Sep 24, 2022

View on GitHub
 (1 comment) (0 reactions) (0 assignees)JavaScript (6,583 stars) (737 forks)batch import
buggood first issueshell

Description

Filing this for tracking right now, it's gotta be a Meteor accounts package issue, and I want to track it down. I have my original Gmail account and my actual email account both in GitHub, because many commits used my old Gmail address, but my GitHub account has the correct primary set, and only the primary is allowed for notifications and such.

However, when I log into a new Sandstorm instance with GitHub, my old Gmail account is also pulled in, and ends up set as the notification/primary address, which means my notifications are lost to the ether (or a Google account I check maybe every other month or so).

Contributor guide

Tech stack
javascriptnodejs
Domain
authenticationbackend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
4
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
needs investigation
Prerequisites
Meteor accounts packageGitHub OAuthEmail handling
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Investigate the Meteor accounts github package to see how it retrieves and sets the primary email. Compare the GitHub API response for the user's emails with the logic in the package. Check the user model to ensure the correct email is stored as primary. Look for any configuration in the Sandstorm codebase that might override the email selection.