sandstorm-io/sandstorm

GitHub authentication doesn't set the correct primary email

Open

#3,665 opened on Sep 24, 2022

View on GitHub
 (1 comment) (0 reactions) (0 assignees)JavaScript (737 forks)batch import
buggood first issueshell

Repository metrics

Stars
 (6,583 stars)
PR merge metrics
 (Avg merge 12d 18h) (6 merged PRs in 30d)

Description

Filing this for tracking right now, it's gotta be a Meteor accounts package issue, and I want to track it down. I have my original Gmail account and my actual email account both in GitHub, because many commits used my old Gmail address, but my GitHub account has the correct primary set, and only the primary is allowed for notifications and such.

However, when I log into a new Sandstorm instance with GitHub, my old Gmail account is also pulled in, and ends up set as the notification/primary address, which means my notifications are lost to the ether (or a Google account I check maybe every other month or so).

Contributor guide

Research direction
Inspect the GitHub OAuth callback handler in the Meteor accounts package to see how it processes email data from the GitHub API response. Ensure that only the primary email address is used for the account's notification settings, not the additional emails.
Tech stack
javascript
Domain
authenticationbackend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitJavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
55