sandstorm-io/sandstorm

Demo tests in `tests/basic.js` are broken.

Open

#3,615 opened on Apr 10, 2022

View on GitHub
 (1 comment) (0 reactions) (0 assignees)JavaScript (737 forks)batch import
good first issuesandstorm-dev

Repository metrics

Stars
 (6,583 stars)
PR merge metrics
 (Avg merge 12d 18h) (6 merged PRs in 30d)

Description

I noticed when picking through the test suite there is logic to explicitly disable demo related tests in tests/basic.js, apparently because at some point they were blocking release and considered not critical.

We should actually fix those eventually.

Contributor guide

Research direction
Examine the demo test logic in tests/basic.js and identify why they are failing or disabled. Enable and fix the tests so they pass.
Tech stack
javascript
Domain
backend
Issue type
Test
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80