sandstorm-io/sandstorm

Demo tests in `tests/basic.js` are broken.

Open

#3615 opened on Apr 10, 2022

View on GitHub
 (1 comment) (0 reactions) (0 assignees)JavaScript (6,583 stars) (737 forks)batch import
good first issuesandstorm-dev

Description

I noticed when picking through the test suite there is logic to explicitly disable demo related tests in tests/basic.js, apparently because at some point they were blocking release and considered not critical.

We should actually fix those eventually.

Contributor guide

Tech stack
javascript
Domain
testing
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Familiarity with tests/basic.jsAbility to reproduce test failures
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Start by examining tests/basic.js to identify which demo tests are disabled and the logic that disables them. Run the test suite to observe the failures. Look at the git history for any previous attempts or discussions. Then propose a plan to fix the failing demo tests.