samrocketman/gitlab-mirrors

Add builds enabled option to config.sh

Open

#90 opened on Dec 4, 2015

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Shell (165 forks)github user discovery
bashenhancementgood first issuehelp wantedpython

Repository metrics

Stars
 (823 stars)
PR merge metrics
 (PR metrics pending)

Description

First discovered in GitLab 8.2.2-ee on GitLab.com.

When creating new projects builds, will are now enabled by default. This should be exposed as an option in config.sh.

diff --git a/lib/manage_gitlab_project.py b/lib/manage_gitlab_project.py
index ac8accf..7c8ec82 100755
--- a/lib/manage_gitlab_project.py
+++ b/lib/manage_gitlab_project.py
@@ -70,6 +70,7 @@ def createproject(pname):
     'snippets_enabled': options.snippets,
     'public': options.public,
     'namespace_id': git.find_group(name=gitlab_namespace).id,
+    'builds_enabled': False
   }
   #make all project options lowercase boolean strings i.e. true instead of True
   for x in project_options.keys():

The config.sh option could be

builds_enabled=true

The default value should be false if config.sh doesn't contain it.

Contributor guide

Research direction
Add 'builds enabled' variable to config.sh and modify manage gitlab project.py to use it.
Tech stack
shellpython
Domain
backend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80