sampotts/plyr

The cdn version of Vimeo's player.js is not appropriate for a <script> tag on a require.js-using site

Open

#420 opened on Nov 10, 2016

View on GitHub
 (6 comments) (0 reactions) (0 assignees)JavaScript (2,856 forks)batch import
Help Wanted

Repository metrics

Stars
 (25,318 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Expected behaviour

Vimeo videos should play correctly

Actual behaviour

A Mismatched Anonymous Define Modules error fires. More info on that error: http://requirejs.org/docs/errors.html#mismatch

Basically, the UMD in player.js is simply not necessary for embedding via a script tag.

Environment

  • Browser: Chrome
  • Version: 54
  • Operating System: OSX
  • Version: 10.11.16

Steps to reproduce

  • Use Plyr.js on a site which uses require.js and load a Vimeo video.

Contributor guide

Research direction
Investigate the UMD (Universal Module Definition) wrapper in Vimeo's player.js CDN version. Check if it uses define() which conflicts with require.js. Look at the Plyr source code to see how it loads the Vimeo player and consider modifying the script tag or using a non UMD version.
Tech stack
javascript
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScriptrequire.js
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70