sampotts/plyr

Keyboard operation of Settings menu on IE not working

Open

#1396 opened on Mar 26, 2019

View on GitHub
 (1 comment) (0 reactions) (0 assignees)JavaScript (25,318 stars) (2,856 forks)batch import
BugHelp Wanted

Description

Expected behaviour

With the settings menu open, up and down arrow should move the focus between the menu items.

Actual behaviour

Up and down arrow do not work. Tab key does something, but not according to the w3c recommendations.

Steps to reproduce

Open the demo site (plyr.io) with MSIE. Tab to the settings menu. Open it with ENTER.

Environment

  • Browser: MSIE
  • Version: 11
  • Operating System: Win
  • Version:8.1

Console errors (if any)

Link to where the bug is happening

https://plyr.io/

Contributor guide

Tech stack
javascripthtml
Domain
frontendaccessibility
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
JavaScript keyboard eventsIE compatibilityplyr settings component
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Investigate the plyr settings menu implementation in the JavaScript source code, likely in `src/js/settings.js`. Examine how keyboard events are handled for navigation. Test in IE 11 using a virtual machine or BrowserStack. Ensure that arrow keys trigger focus movement as per WAI ARIA menu pattern. Consider adding keydown event listeners for ArrowUp and ArrowDown to move focus between menu items, and ensure Tab key works correctly. Refer to the demo site at plyr.io for reproduction.