sampotts/plyr

Settings menu disappears on click when video is playing

Open

#1122 opened on Jul 25, 2018

View on GitHub
 (6 comments) (0 reactions) (0 assignees)JavaScript (25,318 stars) (2,856 forks)batch import
BugHelp WantedReplicated

Description

Expected behaviour

When clicking on the settings to change quality, or play speed, the menu disappears, clicking on the menu again, shows the specific settings menu, as I clicked before. The issue doesn't reproduce when video is paused, clicking on the settings button and then on Quality, will show me the quality options without the menu disappearing.

Actual behaviour

The menu shouldn't disappear, even when video is playing.

Environment

Tested on the Plyr website: https://plyr.io/

  • Browser: Chrome
  • Version: Version 67.0.3396.99 (Official Build) (64-bit)
  • Operating System: Windows 10
  • Version: 1803

Steps to reproduce

  • When video is playing, click on the settings button.
  • Next, click on one of the options, say Quality.
  • The menu should disappear now, clicking on the settings button again, should display the quality options.
  • Doing the same process when the video is paused, the menu would not disappear on click.

Contributor guide

Tech stack
javascripthtmlcss
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
JavaScriptHTML/CSSBasic debugging skills
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
The bug is in the settings menu behavior during video playback. Investigate the menu event handling in the Plyr source, likely in src/js/settings.js or a similar UI component. The menu disappears on click only when the video is playing, suggesting a condition that closes the menu prematurely. Check for event listeners that may be triggered by video playback events (e.g., timeupdate) or a timeout that is cleared when paused. Look at the #1122 issue comments for any additional clues, and consider fixing by preventing menu close on click when a submenu option is selected.