sampotts/plyr

Muting doesn't work for Vimeo videos in Chrome.

Open

#1084 opened on Jul 3, 2018

View on GitHub
 (5 comments) (4 reactions) (0 assignees)JavaScript (25,318 stars) (2,856 forks)batch import
BugHelp Wanted

Description

Expected behaviour

To be able to add the muted: true property to the Plyr constructor and the video to be muted.

Actual behaviour

Video plays with sounds in Chrome.

  • Browser: Chrome
  • Version: 67.0.3396.99
  • Operating System: MacOS
  • Version: 10.13.3

Steps to reproduce

Create a div with provider set to vimeo and pass through the vimeo video id with data-plyr-embed-id. Instantiate the video with var hero_video = new Plyr('#hero_player_plyr', { autoplay: true, muted: true, volume: 0, controls: [] });

Contributor guide

Tech stack
javascript
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
JavaScriptPlyr library understanding
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75
Research direction
The issue is that the `muted` property is not being applied to Vimeo videos in Chrome. Investigate the Vimeo provider implementation in Plyr (likely `src/js/providers/vimeo.js`). Check how the `muted` option is passed to the Vimeo embed API. Compare with the HTML5 provider where muting works. Also review the existing comments for additional insights. A potential fix might involve setting the `muted` attribute on the Vimeo iframe or adjusting the Vimeo player parameters.