sampotts/plyr

IE browser Set the plyr.source Enter the event ended

Open

#1,008 opened on Jun 7, 2018

View on GitHub
 (7 comments) (4 reactions) (0 assignees)JavaScript (2,856 forks)batch import
Browser IssueHelp Wanted

Repository metrics

Stars
 (25,318 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Expected behaviour

Set the plyr.source,Do not enter the event ended

Actual behaviour

IE browser Set the plyr.source Enter the event ended

Environment

  • Browser: IE11
  • Version: 3.3.10
  • Operating System: win10
  • Version:

Steps to reproduce

this.plyrInstances.on('ended', () => { alert(1) });

this.plyrInstances.source = { type: 'video', title: 'video', sources: [{ src:'xx.mp4', type: 'video/mp4' }, ], }

Contributor guide

Research direction
Investigate the Plyr source code to understand how setting 'source' triggers events. Reproduce the issue in IE11 and trace the code path. Compare with other browsers to identify what differs. Look for event dispatching logic in the source setter or related methods.
Tech stack
javascript
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScriptBrowser testing
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70