sampotts/plyr

IE browser Set the plyr.source Enter the event ended

Open

#1008 opened on Jun 7, 2018

View on GitHub
 (7 comments) (4 reactions) (0 assignees)JavaScript (25,318 stars) (2,856 forks)batch import
Browser IssueHelp Wanted

Description

Expected behaviour

Set the plyr.source,Do not enter the event ended

Actual behaviour

IE browser Set the plyr.source Enter the event ended

Environment

  • Browser: IE11
  • Version: 3.3.10
  • Operating System: win10
  • Version:

Steps to reproduce

this.plyrInstances.on('ended', () => { alert(1) });

this.plyrInstances.source = { type: 'video', title: 'video', sources: [{ src:'xx.mp4', type: 'video/mp4' }, ], }

Contributor guide

Tech stack
javascripthtmlcss
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
JavaScriptPlyr library basicsBrowser debugger
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Investigate the Plyr source code, particularly the `source` setter and the 'ended' event handling. Check the media element's event listeners and ensure that setting the source does not inadvertently trigger 'ended' in IE11. Look for any browser specific workarounds or event cleanup needed. Consider testing with a virtual machine or browser emulation to reproduce the issue.