saltstack/salt

pythonversion breaks "_info" pattern of other grains.

Open

#59,594 opened on Feb 23, 2021

View on GitHub
 (5 comments) (0 reactions) (0 assignees)Python (13,710 stars) (5,508 forks)batch import
Grainsbuggood first issuehelp-wantedseverity-low

Description

Description of Issue

pythonversion grain breaks model of fooversion/release and fooinfo

What I mean by that is that pythonversion is not a simple string or int, but instead a list.

pythonversion:
    - 2
    - 7
    - 5
    - final
    - 0

It should instead be like 'osrelease: 7.9.2009' with the list varient named pythonversion_info.

I'm well aware this is a problematic and backwards incompatible change.

May I suggest adding "pythonrelease: 2.7.5" and "pythonrelease_info: [2, 7, 5, final, 0]" grains? Then at some well documented future date having pythonversion go away.

Setup

Any salt version, at least through 3002.2

Steps to Reproduce Issue

salt-call grains.item pythonversion local: ---------- pythonversion: - 2 - 7 - 5 - final - 0

Versions Report

(Provided by running salt --versions-report. Please also mention any differences in master/minion versions.) salt --versions-report Salt Version: Salt: 3002.2

Dependency Versions: cffi: Not Installed cherrypy: Not Installed dateutil: Not Installed docker-py: Not Installed gitdb: 0.6.4 gitpython: 1.0.1 Jinja2: 2.11.1 libgit2: Not Installed M2Crypto: 0.35.2 Mako: Not Installed msgpack: 0.6.2 msgpack-pure: Not Installed mysql-python: Not Installed pycparser: Not Installed pycrypto: 2.6.1 pycryptodome: Not Installed pygit2: Not Installed Python: 3.6.8 (default, Nov 16 2020, 16:55:22) python-gnupg: Not Installed PyYAML: 3.13 PyZMQ: 17.0.0 smmap: 0.9.0 timelib: Not Installed Tornado: 4.5.3 ZMQ: 4.1.4

System Versions: dist: centos 7 Core locale: UTF-8 machine: x86_64 release: 3.10.0-1160.15.2.el7.x86_64 system: Linux version: CentOS Linux 7 Core

Contributor guide

Tech stack
python
Domain
infrastructurebackend
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Familiarity with Salt grainsPython development
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65
Research direction
The issue proposes adding two new grains: pythonrelease (string like '2.7.5') and pythonrelease info (list like [2,7,5,'final',0]) to replace the current pythonversion list grain. Start by examining the grains directory (salt/grains/) and the core module (salt/grains/core.py) where pythonversion is likely defined. Look for any discussions in the issue comments about backwards compatibility and deprecation strategies. Implementation should add the new grains, update documentation, and mark pythonversion as deprecated. Consider writing tests in tests/unit/grains/.
pythonversion breaks "_info" pattern of other grains. · saltstack/salt#59594 | Good First Issue